Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add creation of kueue resources in e2e tests #616

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Add creation of kueue resources in e2e tests #616

merged 1 commit into from
Sep 30, 2024

Conversation

ChughShilpa
Copy link
Contributor

@ChughShilpa ChughShilpa commented Sep 26, 2024 •
edited
Loading

Issue link

RHOAIENG-11047

What changes have been made

Since we are adjusting e2e tests to run with AMD gpu, thus

  • Adding creation of kueue resources as part of test to make it compatible with gpuresources (which is covered in next PR)
  • Removing creation of kueue resources from setup script
  • Adjust methods with updated Ray cluster client

Verification steps

Run test manually
go test -timeout 30m -v ./test/e2e -run TestMnistPyTorchAppWrapperCpu

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

sutaakar
sutaakar reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@sutaakar sutaakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 27, 2024
@ChughShilpa
Copy link
Contributor Author

@sutaakar @astefanutti
Could someone please approve the PR ?

astefanutti
astefanutti approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We may want to think about a strategy for the creation of cluster resources like ClusterQueues in the context of concurrent execution of tests in the future.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f500555 into project-codeflare:main Sep 30, 2024
8 checks passed
@sutaakar
Copy link
Contributor

We may want to think about a strategy for the creation of cluster resources like ClusterQueues in the context of concurrent execution of tests in the future.

Current strategy is to provide generated name for cluster resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutaakar sutaakar sutaakar left review comments

@astefanutti astefanutti astefanutti approved these changes

@Bobbins228 Bobbins228 Awaiting requested review from Bobbins228

@dimakis dimakis Awaiting requested review from dimakis

Assignees

@astefanutti astefanutti

@sutaakar sutaakar

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChughShilpa @sutaakar @astefanutti @openshift-merge-robot